Skip to content

Decoupled code from DefaultSigningKey #16743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Aug 19, 2021

Decoupled code from DefaultSigningKey. Makes testing a little bit easier and is cleaner.

@KN4CK3R KN4CK3R added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16743 (bd54abd) into main (4debb74) will increase coverage by 0.03%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16743      +/-   ##
==========================================
+ Coverage   45.37%   45.40%   +0.03%     
==========================================
  Files         760      760              
  Lines       85482    85484       +2     
==========================================
+ Hits        38785    38816      +31     
+ Misses      40414    40387      -27     
+ Partials     6283     6281       -2     
Impacted Files Coverage Δ
services/auth/oauth2.go 49.18% <0.00%> (ø)
routers/web/user/oauth.go 37.38% <81.25%> (+0.14%) ⬆️
services/auth/source/oauth2/token.go 72.72% <85.71%> (ø)
modules/proxy/proxy.go 15.15% <0.00%> (-3.60%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
models/repo_list.go 77.64% <0.00%> (-0.79%) ⬇️
modules/queue/workerpool.go 54.96% <0.00%> (+0.38%) ⬆️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
routers/api/v1/repo/pull.go 29.63% <0.00%> (+0.51%) ⬆️
modules/queue/unique_queue_disk_channel.go 48.63% <0.00%> (+1.36%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4debb74...bd54abd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2021
@lunny
Copy link
Member

lunny commented Aug 27, 2021

Please resolve the conflicts.

@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 88abb0d into go-gitea:main Aug 27, 2021
@KN4CK3R KN4CK3R deleted the refactor-default-key branch September 6, 2021 18:28
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants