Use node 14 instead of node 16 as node 14 is LTS #16592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change in node 16 has caused jest to break and thence our CI. This PR changes to use Node 14 instead of 16. Closes go-gitea#16591 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/testing
topic/build
Codecov Report
@@ Coverage Diff @@
## main #16592 +/- ##
==========================================
- Coverage 45.35% 45.35% -0.01%
==========================================
Files 750 750
Lines 85096 85096
==========================================
- Hits 38599 38597 -2
- Misses 40252 40254 +2
Partials 6245 6245
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change in node 16 has caused webpack-cli to break and thence our CI. Ostensibly this has happened because node 16 is not a LTS release.
This PR changes to use Node 14 which is the LTS for node instead of 16.
Closes #16591
Signed-off-by: Andrew Thornton [email protected]