Make getIssueFullPattern() concurrency save - bugfix #16415 (#16155, #16185) #16416
Conversation
|
@Dexus can you please target master first and then we will backport stuff if merged? |
GiteaBot
added
the
lgtm/need 2
| @@ -70,9 +70,6 @@ var ( | |||
| // CSS class for action keywords (e.g. "closes: #1") | |||
| const keywordClass = "issue-keyword" | |||
|
|
|||
| // regexp for full links to issues/pulls | |||
| var issueFullPattern *regexp.Regexp | |||
There was a problem hiding this comment.
Probably an antipattern but the init() function would also work, wouldn't it?
| var issueFullPattern = regexp.MustCompile(regexp.QuoteMeta(setting.AppURL) + | ||
| `\w+/\w+/(?:issues|pulls)/((?:\w{1,10}-)?[1-9][0-9]*)([\?|#]\S+.(\S+)?)?\b`) | ||
|
|
||
| return func() *regexp.Regexp { |
There was a problem hiding this comment.
Offtopic and I don't know go but would this really be needed (creating and calling this function)
|
see #16417 |
|
I'm glad it's fixed, even if it's a pity that you're deprived of your own contribution. |
|
@Dexus I thought about creating the diff and send it to you ... but it was easyer to just submit a pull then ... I of cousre can mention you in the pull if you like beside you did targed the wrong branch :D |
|
That's not my point at all. Find it only a pity and wanted to put it also so to the expression. Anyway, thanks that it was addressed. |
|
@Dexus as per #16417 (comment) I think you can have the cance to a pull now ;) just use sync.Once to init it on first call to the func |
Run processors on whole of text (#16155) #16185
This PR makes the function concurrent save. Fix the mention in PR #16185 and merge 5ff807a
Fixes #16415