Skip to content

Update go-chi binding #16324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 1, 2021

update gitea.com/go-chi/binding

and adapt changes

@codecov-commenter
Copy link

Codecov Report

Merging #16324 (9786b65) into main (290f458) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16324      +/-   ##
==========================================
- Coverage   45.42%   45.37%   -0.05%     
==========================================
  Files         709      709              
  Lines       83611    83611              
==========================================
- Hits        37978    37938      -40     
- Misses      39545    39592      +47     
+ Partials     6088     6081       -7     
Impacted Files Coverage Δ
services/forms/user_form.go 43.90% <ø> (ø)
routers/api/v1/admin/user.go 24.44% <0.00%> (-12.23%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/validation/binding.go 87.12% <0.00%> (-2.98%) ⬇️
services/pull/check.go 25.51% <0.00%> (-2.76%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
models/error.go 38.91% <0.00%> (-0.78%) ⬇️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290f458...9786b65. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 1, 2021
@zeripath
Copy link
Contributor

zeripath commented Jul 2, 2021

Hmm this has a dependency on goccy/json which doesn't work in our tests.

I can't remember if this is exposed outside of binding - if so I suspect we need to remove this dependency on goccy as it might break for us.

@6543 6543 added this to the 1.16.0 milestone Jul 8, 2021
@KN4CK3R KN4CK3R mentioned this pull request Oct 13, 2021
@lunny
Copy link
Member

lunny commented Oct 14, 2021

closed by #17298

@lunny lunny closed this Oct 14, 2021
@lunny lunny removed this from the 1.16.0 milestone Oct 14, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@6543 6543 deleted the update_go-chi_binding branch May 7, 2022 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants