Skip to content

fix get OS on some of the windows computers #16007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2021
Merged

Conversation

BoYanZh
Copy link
Contributor

@BoYanZh BoYanZh commented May 28, 2021

At least on my laptop, $(OS) returns Windows instead of Windows_NT. So I try to fix it.

@BoYanZh BoYanZh closed this May 28, 2021
@BoYanZh BoYanZh reopened this May 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #16007 (f26a356) into main (b4d1059) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16007      +/-   ##
==========================================
+ Coverage   44.02%   44.06%   +0.03%     
==========================================
  Files         682      682              
  Lines       82407    82412       +5     
==========================================
+ Hits        36282    36311      +29     
+ Misses      40218    40202      -16     
+ Partials     5907     5899       -8     
Impacted Files Coverage Δ
modules/auth/sso/reverseproxy.go 8.51% <0.00%> (ø)
services/repository/generate.go 0.00% <0.00%> (ø)
modules/web/middleware/cookie.go 64.65% <66.66%> (+7.75%) ⬆️
modules/markup/markdown/goldmark.go 58.84% <70.00%> (+0.62%) ⬆️
modules/auth/sso/basic.go 44.64% <100.00%> (ø)
modules/auth/sso/sso.go 36.66% <100.00%> (ø)
modules/markup/sanitizer.go 88.88% <100.00%> (ø)
modules/setting/indexer.go 91.42% <100.00%> (ø)
modules/setting/queue.go 67.92% <100.00%> (ø)
routers/repo/pull.go 31.15% <100.00%> (+0.07%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461915d...f26a356. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2021
@zeripath zeripath merged commit fb6c689 into go-gitea:main May 29, 2021
@BoYanZh BoYanZh deleted the patch-1 branch May 29, 2021 10:04
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants