Remove branch URL before IssueRefURL #15968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noerw
suggested changes
May 24, 2021
There was a problem hiding this comment.
Thanks! One nit, see code comment.
Ffor reference; the repoLink is prepended to the URLs here already
Line 167 in cc7e1b8
GiteaBot
added
the
lgtm/need 2
Looks like it's been broken for a long time, then. Seems like few users rely on it 🤔 |
|
Sorry, please revert my suggestion. The non |
noerw
reviewed
May 24, 2021
|
Makes sense to me now, thank you. I should have given the cases a second thought, I just assumed that the data was now contained globally, because both cases had it prepended before. |
Revert change for account / org dashboard where IssueRefURLs do not contain the full repo URL (case RepoLink is not true) Co-authored-by: Norwin <[email protected]> Remove trailing whitespace from PR review
KN4CK3R
approved these changes
May 25, 2021
GiteaBot
added
lgtm/need 1
noerw
approved these changes
May 25, 2021
GiteaBot
added
lgtm/done
techknowlogick
added
the
backport/done
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Revert change for account / org dashboard where IssueRefURLs do not contain the full repo URL (case RepoLink is not true) Co-authored-by: Norwin <[email protected]> Remove trailing whitespace from PR review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #15967 (duplicate Owner/Branch in URL when linking to a branch from an issue).
It appears to me as if
IssueRefURLsalready contain the full valid URL by now and thus prepending the Owner and Branch leads to duplication.