If the default branch is not present do not report error on stats indexing #15546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exing Fix go-gitea#15257 Signed-off-by: Andrew Thornton <[email protected]>
silverwind
approved these changes
Apr 19, 2021
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Apr 19, 2021
GiteaBot
added
lgtm/done
lunny
reviewed
Apr 19, 2021
Signed-off-by: Andrew Thornton <[email protected]>
lunny
approved these changes
Apr 22, 2021
|
Please send back port |
|
This doesn't actually work because the error is not a branch does not exist error - follow-up PR coming up. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 22, 2021
go-gitea#15546 doesn't completely fix this problem because the error returned is an ObjectNotExist error not a BranchNotExist error. Fix go-gitea#15257 Signed-off-by: Andrew Thornton <[email protected]>
6543
pushed a commit
that referenced
this pull request
Apr 22, 2021
…exing (follow-up of #15546) (#15583) #15546 doesn't completely fix this problem because the error returned is an ObjectNotExist error not a BranchNotExist error. Add test for ErrObjectNotExist too Fix #15257 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 22, 2021
…exing (follow-up of go-gitea#15546) (go-gitea#15583) Backport go-gitea#15546 Backport go-gitea#15583 go-gitea#15546 doesn't completely fix this problem because the error returned is an ObjectNotExist error not a BranchNotExist error. Add test for ErrObjectNotExist too Fix go-gitea#15257 Signed-off-by: Andrew Thornton <[email protected]>
6543
pushed a commit
that referenced
this pull request
Apr 22, 2021
…exing (follow-up of #15546) (#15583) (#15594) Backport #15546 Backport #15583 #15546 doesn't completely fix this problem because the error returned is an ObjectNotExist error not a BranchNotExist error. Add test for ErrObjectNotExist too Fix #15257 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just debug log instead
Fix #15257
Signed-off-by: Andrew Thornton [email protected]