Add size to Save function #15264
Merged
Add size to Save function #15264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR proposes an alternative solution to go-gitea#15255 - just add the size to the save function. Yes it is less apparently clean but it may be more correct. Close go-gitea#15255 Fix go-gitea#15253 Signed-off-by: Andrew Thornton <[email protected]>
|
We need some comment to say the size could be |
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Apr 3, 2021
GiteaBot
added
lgtm/need 1
lunny
added
backport/v1.13
performance/memory
lunny
added
the
skip-changelog
6543
changed the title
6543
reviewed
Apr 3, 2021
lunny
approved these changes
Apr 3, 2021
GiteaBot
added
lgtm/done
|
🚀 |
|
Maybe we can wait for adding PartSize to |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 3, 2021
This PR proposes an alternative solution to go-gitea#15255 - just add the size to the save function. Yes it is less apparently clean but it may be more correct. Close go-gitea#15255 Fix go-gitea#15253 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 3, 2021
Backport go-gitea#15264 This PR proposes an alternative solution to go-gitea#15255 - just add the size to the save function. Yes it is less apparently clean but it may be more correct. Close go-gitea#15255 Fix go-gitea#15253 Signed-off-by: Andrew Thornton <[email protected]>
|
@lunny I don't understand - do you have a PR for that? |
techknowlogick
pushed a commit
that referenced
this pull request
Apr 4, 2021
techknowlogick
pushed a commit
that referenced
this pull request
Apr 4, 2021
This PR proposes an alternative solution to #15255 - just add the size to the save function. Yes it is less apparently clean but it may be more correct. Close #15255 Fix #15253 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
|
When |
6543
added
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an alternative solution to #15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.
Close #15255
Fix #15253
Signed-off-by: Andrew Thornton [email protected]