Skip to content

optimization on database IN #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2016
Merged

optimization on database IN #152

merged 1 commit into from
Nov 11, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 11, 2016

This PR will remove all str join but use a sql builder and reduce unused codes.

@thibaultmeyer
Copy link
Contributor

LGTM

@thibaultmeyer thibaultmeyer added this to the 1.0.0 milestone Nov 11, 2016
@thibaultmeyer thibaultmeyer added the type/enhancement An improvement of existing functionality label Nov 11, 2016
@metalmatze
Copy link
Contributor

LGTM

@metalmatze metalmatze merged commit 900f233 into go-gitea:master Nov 11, 2016
@lunny lunny deleted the lunny/optimization_in branch November 12, 2016 00:21
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017
Merge pull request go-gitea#152 from ethantkoenig/fix_tests
16588c4 
Fix CI builds
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @thibaultmeyer @metalmatze @tboerger