Skip to content

Remove env user salt since no need to use #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 19, 2017

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 19, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 19, 2017
@strk
Copy link
Member

strk commented Apr 19, 2017

There's a GetEnv for that variable in cmd/hook.go

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2017
@lunny
Copy link
Member Author

lunny commented Apr 19, 2017

@strk depends on #1514. I'm sorry I forgot that.

@lunny lunny force-pushed the lunny/rm_unused_codes branch from 245bfd0 to a0f4082 Compare May 5, 2017 02:24
@lunny
Copy link
Member Author

lunny commented May 5, 2017

It's ready for review now sinc #1514 merged.

@lafriks
Copy link
Member

lafriks commented May 5, 2017

It should be also removed from models/update.go as it is not used anymore then

@lunny
Copy link
Member Author

lunny commented May 6, 2017

done. @lafriks

@lafriks
Copy link
Member

lafriks commented May 6, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 6, 2017
@appleboy
Copy link
Member

appleboy commented May 6, 2017

LGTM

@appleboy
Copy link
Member

appleboy commented May 6, 2017

make L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2017
@appleboy appleboy merged commit 930d175 into go-gitea:master May 6, 2017
@lunny lunny deleted the lunny/rm_unused_codes branch May 6, 2017 13:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants