Skip to content

Fix excluding more than two labels on issues list #14962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zeripath
Copy link
Contributor

Fix #14840

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 11, 2021
@zeripath zeripath added this to the 1.14.0 milestone Mar 11, 2021
@noerw

This comment has been minimized.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 12, 2021
@noerw noerw added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Mar 12, 2021
@noerw noerw removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Mar 12, 2021
Copy link
Contributor

@jaqra jaqra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit. otherwise lgtm. just remove can be confusing

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2021
@jaqra
Copy link
Contributor

jaqra commented Mar 12, 2021

@zeripath sorry for bothering suggestion

@lunny lunny merged commit ccfb205 into go-gitea:master Mar 12, 2021
@zeripath zeripath deleted the fix-14840-make-excluding-more-than-two-labels-work branch March 12, 2021 16:28
@zeripath
Copy link
Contributor Author

@zeripath sorry for bothering suggestion

No don't worry - better to get this stuff fixed now.

zeripath added a commit to zeripath/gitea that referenced this pull request Mar 12, 2021
Backport go-gitea#14962

Fix go-gitea#14840

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: Norwin Roosen <[email protected]>
Co-authored-by: jaqra <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 12, 2021
6543 pushed a commit that referenced this pull request Mar 12, 2021
Backport #14962

Fix #14840

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: Norwin Roosen <[email protected]>
Co-authored-by: jaqra <[email protected]>

Co-authored-by: Norwin Roosen <[email protected]>
Co-authored-by: jaqra <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Excluding more than two labels does not work
5 participants