Skip to content

Show correct issues for team dashboard #14952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Show correct issues for team dashboard #14952

merged 5 commits into from
Mar 12, 2021

Conversation

noerw
Copy link
Member

@noerw noerw commented Mar 11, 2021

  1. fix no items under /org/$org/{issues,pulls}?type=mentioned
    It was filtering by org id, but org-mentions are not persisted like that to the DB, we need to filter by UID.
    This means, selecting different teams will only have an effect on the selected repos, all other filters will give same results between teams.
  2. don't spam a warning for a perfectly fine request

fixes #14941

noerw added 2 commits March 11, 2021 10:44
it was filtering by org id, but org-mentions are not persisted like that
to the DB, we need to filter by UID.
This means, selecting different teams will only have an effect on the
selected repos, otherwise results will be the same, which may be
suboptimal.

fixes go-gitea#14941
@noerw noerw added the type/bug label Mar 11, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 11, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2021
@6543 6543 added this to the 1.14.0 milestone Mar 12, 2021
@6543 6543 mentioned this pull request Mar 12, 2021
1 task
@6543 6543 merged commit df76d9f into go-gitea:master Mar 12, 2021
@6543 6543 deleted the fix-14941 branch March 12, 2021 03:06
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/org/gitea/issues?type=mentioned does not list any issues
4 participants