Skip to content

Fix dashboard UI bugs and more #14767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Conversation

CL-Jeremy
Copy link
Contributor

This PR fixes a few UI bugs I spontaneously encountered:

  • Fixes emojis in repo titles getting head-cut and tail-cut in dashboard feed due to introduction of 1.25 em emojis at 1 em line-height, by simply using the original 1 3/7 em value of semantic.css
  • Fixes regression (too long repo names should be capped to 70%) in Style and template tweaks #13828 due to flex children not respecting properties like overflow: hidden;, and removes a block of dead style code
  • Follow-up to SVG Spacing restricted to direct descendants of items #14761, removes extraneous code for top navbar and correct right margin for Font Awesome
  • Fixes color emphasis inversion in arc-green theme for top right buttons (edit, delete) on commit view boxes

@CL-Jeremy
Copy link
Contributor Author

Just came to the idea to use the server octicon for admin settings. Looks pretty understandable to me. Will add if people like it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2021
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 22, 2021
@lunny
Copy link
Member

lunny commented Feb 22, 2021

Could you give some screenshots?

@CL-Jeremy
Copy link
Contributor Author

Snipaste_2021-02-22_06-22-33

.ui.menu .ui.dropdown .menu > .selected.item {
color: var(--color-text) !important;
background: var(--color-hover) !important;
.ui.menu .ui.dropdown .menu {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylelint is complaining about the extra space here. Will fix this later. Waiting for reactions regarding switching to
octicon-server.svg Site Administration

@6543 6543 added this to the 1.14.0 milestone Feb 23, 2021
@6543 6543 added the type/bug label Feb 23, 2021
@CL-Jeremy
Copy link
Contributor Author

@noerw seems to be confused about what I meant to replace with the server icon. It's this button here. Do you think it's a good replacement to the triple gear icon?

Currently in this PR:
Bildschirmfoto 2021-02-24 um 09 41 34

Proposal:
Bildschirmfoto 2021-02-24 um 09 35 27

@CL-Jeremy
Copy link
Contributor Author

Pushing for now so I won't forget about it if PR takes too long. Will revert last commit if people object the change.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2021
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2021
@6543 6543 merged commit 4172b19 into go-gitea:master Feb 25, 2021
@CL-Jeremy CL-Jeremy deleted the ui-fix-dashboard-etc branch February 27, 2021 00:41
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants