Skip to content

Fix JSON Header response #14499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix JSON Header response #14499

merged 1 commit into from
Jan 27, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 27, 2021

as title

@6543 6543 added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 27, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 27, 2021
@jolheiser jolheiser changed the title Fix JSON Header responce Fix JSON Header response Jan 27, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #14499 (0ea1fae) into master (41c0776) will increase coverage by 0.00%.
The diff coverage is 12.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14499   +/-   ##
=======================================
  Coverage   42.09%   42.09%           
=======================================
  Files         758      760    +2     
  Lines       81106    81124   +18     
=======================================
+ Hits        34139    34152   +13     
- Misses      41386    41390    +4     
- Partials     5581     5582    +1     
Impacted Files Coverage Δ
modules/auth/sso/sso.go 26.92% <ø> (-5.22%) ⬇️
modules/context/access_log.go 0.00% <0.00%> (ø)
routers/api/v1/api.go 78.63% <0.00%> (-0.22%) ⬇️
routers/routes/base.go 24.03% <ø> (+5.38%) ⬆️
routers/routes/web.go 91.54% <0.00%> (ø)
modules/context/context.go 58.48% <5.88%> (-2.55%) ⬇️
modules/context/response.go 80.00% <25.00%> (-4.38%) ⬇️
modules/auth/sso/oauth2.go 47.61% <100.00%> (ø)
modules/middlewares/request.go 100.00% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5266a...0ea1fae. Read the comment docs.

@jolheiser jolheiser merged commit a7cfb9f into go-gitea:master Jan 27, 2021
@6543 6543 deleted the fix-JSON branch January 27, 2021 22:36
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants