Skip to content

Fix wrong publisher id #14212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 1, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 1, 2021

Should fix #13713

@lunny lunny added this to the 1.14.0 milestone Jan 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 1, 2021
@codecov-io
Copy link

codecov-io commented Jan 1, 2021

Codecov Report

Merging #14212 (c540f49) into master (0f99edf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14212      +/-   ##
==========================================
- Coverage   42.02%   42.01%   -0.01%     
==========================================
  Files         734      734              
  Lines       78772    78773       +1     
==========================================
- Hits        33104    33099       -5     
- Misses      40235    40241       +6     
  Partials     5433     5433              
Impacted Files Coverage Δ
services/release/release.go 45.37% <0.00%> (-3.23%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.00% <0.00%> (-8.00%) ⬇️
modules/git/repo_commit_nogogit.go 63.33% <0.00%> (-1.67%) ⬇️
models/error.go 38.49% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 42.85% <0.00%> (+0.50%) ⬆️
modules/git/batch_reader_nogogit.go 46.26% <0.00%> (+1.49%) ⬆️
modules/git/repo_language_stats_nogogit.go 63.82% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f99edf...c540f49. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2021
@techknowlogick techknowlogick merged commit 8c086ba into go-gitea:master Jan 1, 2021
@techknowlogick
Copy link
Member

@lunny please send backport

@lunny lunny deleted the lunny/fix_wrong_publisherID branch January 2, 2021 01:49
@lunny
Copy link
Member Author

lunny commented Jan 2, 2021

@techknowlogick Sorry, the bug is only at v1.14 .

@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release publisher is not right when publish a release in UI
6 participants