Skip to content

Normalize files with gofmt #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2016
Merged

Normalize files with gofmt #142

merged 1 commit into from
Nov 11, 2016

Conversation

thibaultmeyer
Copy link
Contributor

@thibaultmeyer thibaultmeyer commented Nov 11, 2016 •
edited
Loading

Normalize Gitea Go files with the command gofmt

@thibaultmeyer thibaultmeyer added this to the 1.0.0 milestone Nov 11, 2016
@thibaultmeyer thibaultmeyer added the type/enhancement An improvement of existing functionality label Nov 11, 2016
@andreynering
Copy link
Contributor

LGTM

1 similar comment
@tboerger
Copy link
Member

LGTM

@tboerger tboerger merged commit 5fc370e into go-gitea:master Nov 11, 2016
@metalmatze
Copy link
Contributor

Thanks it always bugs me. How about we make gofmt mandatory?

@lunny
Copy link
Member

lunny commented Nov 11, 2016

make lint on CI after we fix all the lint errors.

@thibaultmeyer thibaultmeyer deleted the feature/gofmt branch November 12, 2016 10:58
@strk
Copy link
Member

strk commented Nov 12, 2016

On Fri, Nov 11, 2016 at 09:23:22AM -0800, Lunny Xiao wrote:

make lint on CI after we fix all the lint errors.

Please expose a make dev-setup too, to install relevant
git hooks to ensure style upon commit :)

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@adelowo @zeripath
get branch from commit sha1 (go-gitea#142)
fbe468c
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thibaultmeyer @andreynering @tboerger @metalmatze @lunny @strk