Skip to content

Custom icons for OAuth sources #14161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 28, 2020
Merged

Custom icons for OAuth sources #14161

merged 7 commits into from
Dec 28, 2020

Conversation

leytilera
Copy link
Contributor

This adds just a simple option, to set custom icons for the OAuth login sources. If you are using multiple OpenID Connect sources, this is very useful, because you can add icons, that actually fit to the login source and not just the default OpenID logo.

@codecov-io
Copy link

codecov-io commented Dec 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@25f8970). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14161   +/-   ##
=========================================
  Coverage          ?   42.01%           
=========================================
  Files             ?      733           
  Lines             ?    78701           
  Branches          ?        0           
=========================================
  Hits              ?    33068           
  Misses            ?    40200           
  Partials          ?     5433           
Impacted Files Coverage Δ
models/login_source.go 27.51% <ø> (ø)
models/oauth2.go 31.81% <0.00%> (ø)
modules/auth/auth_form.go 100.00% <ø> (ø)
routers/admin/auths.go 35.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f8970...207f312. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2020
@zeripath zeripath added topic/ui Change the appearance of the Gitea UI topic/authentication labels Dec 27, 2020
@zeripath zeripath added this to the 1.14.0 milestone Dec 27, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2020
@6543 6543 merged commit 2b2a4a5 into go-gitea:master Dec 28, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/authentication topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants