Locale: say another issue instead of this issue #14082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saying "this issue" is confusing because it could be understood as the issue that the user is currently viewing, not which the "issue" link points to.
techknowlogick
approved these changes
Dec 21, 2020
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #14082 +/- ##
=======================================
Coverage 42.32% 42.33%
=======================================
Files 726 726
Lines 77689 77689
=======================================
+ Hits 32884 32887 +3
+ Misses 39407 39405 -2
+ Partials 5398 5397 -1
Continue to review full report at Codecov.
|
CirnoT
approved these changes
Dec 21, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Dec 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying "this issue" is confusing because it could be understood as the issue that the user is currently viewing, not which the "issue" link points to.
Was confused by this and thought that an error occurred and it won't let me starting time tracking.