Disable WYSIWYG editor for mobile user agents [rebased on v1.13] #14022
Conversation
Written by @ashimokawa for codeberg.org here https://codeberg.org/Codeberg/build-deploy-gitea/commit/840fd48cad0c72933becafbe561addc6cdfb11e2 This PR adds a "custom header" that acts as if a user clicks on the "disable WYSIWYG" button if their user agent suggests a mobile device. This is clearly only a temporary high-level hotfix for the problem until a more permanent solution is figured out.
corneliusroemer
changed the title
| @@ -0,0 +1,14 @@ | |||
| <script> | |||
There was a problem hiding this comment.
we can not use custom
this has to go into https://github.com/go-gitea/gitea/blob/release/v1.13/templates/base/head.tmpl
There was a problem hiding this comment.
Custom is where Codeberg put it, makes sense that if it's built in to Gitea, that it's in base.
How do I give you permission to change these things? Allow you to push to my fork? Or do that myself? Or something else?
GiteaBot
added
the
lgtm/need 2
|
It should not just load mde editor if on mobile and code should not go inside template, I will submit a PR to fix it that way in a bit |
|
@corneliusroemer thanks for your effort If you still like to contribute to gitea - there are easy issues to pickup (not as hard as this one ;) ) |
Written by @ashimokawa for codeberg.org here https://codeberg.org/Codeberg/build-deploy-gitea/commit/840fd48cad0c72933becafbe561addc6cdfb11e2
This PR adds a "custom header" that acts as if a user clicks on the "disable WYSIWYG" button if their user agent suggests a mobile device.
This is clearly only a temporary high-level hotfix for the problem until a more permanent solution is figured out.
I closed the original PR since it was based on "master", now the commit is based on "v1.13" - not sure whether the closing/recreation was necessary. Happy if someone shows me how I could have done it better (I rebased --onto locally)
#14017