Skip to content

Report permissions denied in internal SSH #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zeripath
Copy link
Contributor

This PR standardizes reporting of permission denied from the internal ssh.

Signed-off-by: Andrew Thornton [email protected]

This PR standardizes reporting of permission denied from the internal ssh.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 11, 2020
@zeripath zeripath added this to the 1.14.0 milestone Dec 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #13953 (78e68af) into master (f2f99a7) will decrease coverage by 0.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13953      +/-   ##
==========================================
- Coverage   42.14%   42.12%   -0.02%     
==========================================
  Files         710      710              
  Lines       77211    77219       +8     
==========================================
- Hits        32537    32531       -6     
- Misses      39325    39336      +11     
- Partials     5349     5352       +3     
Impacted Files Coverage Δ
modules/ssh/ssh.go 44.21% <27.27%> (-1.83%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
services/pull/check.go 48.17% <0.00%> (-3.65%) ⬇️
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f99a7...78e68af. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2020
@zeripath
Copy link
Contributor Author

I've marked this as backport as I think this is likely to be helpful to other places

@6543 6543 merged commit e46a638 into go-gitea:master Dec 11, 2020
@zeripath zeripath deleted the properly-report-permission-denied-in-ssh branch December 11, 2020 22:58
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 12, 2020
Continuing on from go-gitea#13953 continue to improve and standardise
logging from internal SSH.

Also updates the fail2ban setup

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Dec 12, 2020
zeripath added a commit that referenced this pull request Dec 15, 2020
…#13962)

Continuing on from #13953 continue to improve and standardise
logging from internal SSH.

Also updates the fail2ban setup

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Copy link
Contributor Author

I've removed backport as it would break fail2ban configurations in the wild.

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants