Skip to content

Add cloudron to img-src CSP #13887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Add cloudron to img-src CSP #13887

merged 1 commit into from
Dec 7, 2020

Conversation

jolheiser
Copy link
Member

As title, it's currently broken.

cloudron1
cloudron2

@jolheiser jolheiser added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 7, 2020
@jolheiser jolheiser merged commit 991ab89 into go-gitea:master Dec 7, 2020
@jolheiser jolheiser deleted the cloudron branch December 7, 2020 16:33
@jolheiser
Copy link
Member Author

Ughhh, https://cloudron.io/img/button.svg redirects to https://www.cloudron.io/img/button.svg, so it's still busted. 😓

I'm not overly familiar with CSP directives, would https://*.cloudron.io work, or would it need to be *.cloudron.io? Or is it better to just also add https://www.cloudron.io?

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolheiser @silverwind @lafriks @GiteaBot