Skip to content

Fix margin between icon and repo name on dashboard #13876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Dec 6, 2020

Before:
firefox_2020-12-06_18-49-32

After:
firefox_2020-12-06_18-49-11

The same margin (2px) is applied on Organizations tab as mr-2 but on icon itself; I haven't figured out how to apply it on Repository tab due to usage of dynamic Vue components there.

@codecov-io
Copy link

Codecov Report

Merging #13876 (f6859ba) into master (f74a094) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13876      +/-   ##
==========================================
- Coverage   42.27%   42.24%   -0.04%     
==========================================
  Files         708      708              
  Lines       77190    77190              
==========================================
- Hits        32632    32608      -24     
- Misses      39200    39212      +12     
- Partials     5358     5370      +12     
Impacted Files Coverage Δ
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 93.05% <0.00%> (-2.78%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.19%) ⬇️
services/mirror/mirror.go 15.78% <0.00%> (-1.11%) ⬇️
models/notification.go 66.25% <0.00%> (-0.99%) ⬇️
models/error.go 38.17% <0.00%> (-0.82%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 40.68% <0.00%> (-0.50%) ⬇️
modules/notification/mail/mail.go 39.08% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74a094...f6859ba. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 7, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Dec 7, 2020
@lafriks lafriks added this to the 1.14.0 milestone Dec 7, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 7, 2020
@silverwind
Copy link
Member

Actually #13860 already includes a (better) fix for this if you want to check it out. Sorry for not separating it out onto its own PR.

@CirnoT CirnoT closed this Dec 8, 2020
@CirnoT CirnoT deleted the patch-1 branch December 12, 2020 00:35
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants