Set RUN_MODE prod by default #13765
Merged
Set RUN_MODE prod by default #13765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's a bad default to have "dev" as the default run mode which enables debugging and now also disables HTTP caching. It's better to just default to a value suitable for general deployments.
techknowlogick
added
backport/v1.13
pr/breaking
techknowlogick
approved these changes
Nov 30, 2020
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Nov 30, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Nov 30, 2020
|
@silverwind plz backport ;) |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Nov 30, 2020
I think it's a bad default to have "dev" as the default run mode which enables debugging and now also disables HTTP caching. It's better to just default to a value suitable for general deployments. Co-authored-by: techknowlogick <[email protected]>
techknowlogick
added
the
backport/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Nov 30, 2020
Missed that part in go-gitea#13765. It's already in the 1.13 backport so this forward-ports that change again.
lunny
pushed a commit
that referenced
this pull request
Dec 1, 2020
Missed that part in #13765. It's already in the 1.13 backport so this forward-ports that change again.
lunny
pushed a commit
that referenced
this pull request
Dec 1, 2020
* Set RUN_MODE prod by default (#13765) I think it's a bad default to have "dev" as the default run mode which enables debugging and now also disables HTTP caching. It's better to just default to a value suitable for general deployments. Co-authored-by: techknowlogick <[email protected]> * flip default in checkRunMode Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a bad default to have "dev" as the default run mode which enables debugging and now also disables HTTP caching. It's better to just default to a value suitable for general deployments.