Skip to content

Add review pending filter on pull request overview #13702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Nov 25, 2020

Related to #13682

This adds a filter on the pull request overview pages that allows you to find the pull requests for which you have pending review comments. There were some concerns raised in the ticket about not overloading the UI with too many filtering options though.

From my point of view, this filter would be quite useful so you don't lose track of unsubmitted review comments.
But I think the "Review Requested" filter in #13701 is more critical (also exists on GitHub).

@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #13702 (216c227) into master (e7b47c5) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13702      +/-   ##
==========================================
- Coverage   42.19%   42.17%   -0.02%     
==========================================
  Files         697      697              
  Lines       76825    76865      +40     
==========================================
+ Hits        32418    32421       +3     
- Misses      39059    39092      +33     
- Partials     5348     5352       +4     
Impacted Files Coverage Δ
routers/user/home.go 60.11% <0.00%> (-0.49%) ⬇️
models/issue.go 55.84% <16.12%> (-1.07%) ⬇️
routers/repo/issue.go 38.06% <93.10%> (+0.06%) ⬆️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/pull.go 40.68% <0.00%> (-0.50%) ⬇️
services/pull/check.go 49.63% <0.00%> (+0.72%) ⬆️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b47c5...216c227. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2020
@jpraet jpraet force-pushed the 13682-pending-review-filter branch from 91512ee to 216c227 Compare November 28, 2020 10:32
@jpraet jpraet closed this Jan 17, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants