Skip to content

Format files #13698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 28, 2020
Merged

Format files #13698

merged 12 commits into from
Nov 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 25, 2020

as title ...

It's anoing to see many lines of diff if you edit one of this files and the editor automaticaly correct unrelated things.

this pull format files so there will be less + fix alignment of "make help"

this pull does not change any behaviour

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 25, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2020
@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #13698 (8b66c54) into master (742e21a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13698      +/-   ##
==========================================
- Coverage   42.20%   42.19%   -0.01%     
==========================================
  Files         697      697              
  Lines       76825    76825              
==========================================
- Hits        32423    32418       -5     
- Misses      39057    39058       +1     
- Partials     5345     5349       +4     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/queue/manager.go 62.13% <0.00%> (-2.96%) ⬇️
routers/api/v1/repo/pull.go 24.84% <0.00%> (-0.61%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 40.68% <0.00%> (ø)
models/repo_list.go 79.46% <0.00%> (+0.89%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742e21a...8b66c54. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2020
@lafriks
Copy link
Member

lafriks commented Nov 27, 2020

🚀

@techknowlogick techknowlogick merged commit e7b47c5 into go-gitea:master Nov 28, 2020
@6543 6543 deleted the format-files branch November 28, 2020 12:01
silverwind added a commit to silverwind/gitea that referenced this pull request Nov 28, 2020
These whitespaces introduced in go-gitea#13698 seem to break my editorconfig
plugin in sublime text resulting in tab-indented files getting converted
to spaces on save.
@silverwind silverwind mentioned this pull request Nov 28, 2020
lafriks added a commit that referenced this pull request Nov 28, 2020
These whitespaces introduced in #13698 seem to break my editorconfig
plugin in sublime text resulting in tab-indented files getting converted
to spaces on save.

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants