skip email validation on empty string #13627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/bug
type/refactoring
Codecov Report
@@ Coverage Diff @@
## master #13627 +/- ##
=======================================
Coverage 42.20% 42.20%
=======================================
Files 697 697
Lines 76589 76597 +8
=======================================
+ Hits 32325 32331 +6
+ Misses 38948 38947 -1
- Partials 5316 5319 +3
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Nov 19, 2020
GiteaBot
added
lgtm/need 1
|
regression of #13475 - so I'll add skip-changelog label |
6543
added
the
skip-changelog
lafriks
approved these changes
Nov 19, 2020
GiteaBot
added
lgtm/done
lafriks
reviewed
Nov 19, 2020
- move validation into its own function - use a session for UpdateUserSetting
6543
force-pushed
the
fix_refactor-validate-email
branch
from
fcaa90d to
5aab44f
Compare
|
@lafriks done |
lafriks
approved these changes
Nov 20, 2020
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Nov 21, 2020
- move validation into its own function - use a session for UpdateUserSetting
techknowlogick
added a commit
that referenced
this pull request
Nov 22, 2020
* Add email validity check (#13475) * Improve error feedback for duplicate deploy keys Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists. * API returns 422 error when key with name exists * Add email validity checking Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails * Add further tests * Add signup email tests * Add email validity check for linking existing account * Address PR comments * Remove unneeded DB session * Move email check to updateUser Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]> * skip email validation on empty string (#13627) - move validation into its own function - use a session for UpdateUserSetting * rm TODO for backport Co-authored-by: Chris Shyi <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
This was referenced Nov 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13587
close #13653