Skip to content

Improve strings #13548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2020
Merged

Improve strings #13548

merged 6 commits into from
Nov 21, 2020

Conversation

noerw
Copy link
Member

@noerw noerw commented Nov 13, 2020

Minor improvements to en-US locale, adapting to changes in handling of external account linking (when linking accounts a password is not required anymore)

When linking accounts, a password is not required anymore,
so this string becomes confusing
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2020
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Nov 14, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 15, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2020
@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #13548 (12625ca) into master (c5f6f8f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13548      +/-   ##
==========================================
+ Coverage   42.23%   42.24%   +0.01%     
==========================================
  Files         697      697              
  Lines       76576    76576              
==========================================
+ Hits        32340    32351      +11     
+ Misses      38919    38915       -4     
+ Partials     5317     5310       -7     
Impacted Files Coverage Δ
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
services/mailer/mail.go 60.21% <0.00%> (-1.08%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
services/pull/check.go 51.82% <0.00%> (ø)
modules/notification/mail/mail.go 39.08% <0.00%> (ø)
models/error.go 37.08% <0.00%> (+0.33%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f6f8f...12625ca. Read the comment docs.

@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 20, 2020
@techknowlogick techknowlogick merged commit b651409 into go-gitea:master Nov 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants