Skip to content

Create tag on ui #13467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 28, 2021
Merged

Create tag on ui #13467

merged 22 commits into from
Feb 28, 2021

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Nov 8, 2020

  1. Support create single tag directly
    Peek 2020-11-09 00-11

  2. support create tag with message from create release ui
    Peek 2020-11-09 12-25

@lafriks
Copy link
Member

lafriks commented Nov 8, 2020

Wouldn't it be better to to that from specific form like release where you can also input tag message?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 8, 2020
@silverwind
Copy link
Member

Agree, tags have messages, even if we don't display them yet, so there needs to be a form probably (thought I personally don't mind creating tags on CLI only).

@6543
Copy link
Member

6543 commented Nov 8, 2020

I would considder this a feature or enhancement but not a bugfix

@a1012112796 a1012112796 changed the title fix create tag on ui Create tag on ui Nov 9, 2020
@a1012112796
Copy link
Member Author

@codecov-io waiting result :)

@6543 6543 added the type/enhancement An improvement of existing functionality label Nov 9, 2020
@jolheiser jolheiser added this to the 1.14.0 milestone Nov 10, 2020
@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #13467 (2a6115d) into master (3e65286) will decrease coverage by 0.01%.
The diff coverage is 29.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13467      +/-   ##
==========================================
- Coverage   42.23%   42.21%   -0.02%     
==========================================
  Files         771      771              
  Lines       82185    82239      +54     
==========================================
+ Hits        34708    34721      +13     
- Misses      41827    41856      +29     
- Partials     5650     5662      +12     
Impacted Files Coverage Δ
modules/forms/repo_branch_form.go 100.00% <ø> (ø)
modules/forms/repo_form.go 37.74% <ø> (ø)
routers/api/v1/repo/release.go 34.67% <0.00%> (ø)
routers/repo/release.go 24.65% <6.25%> (-0.99%) ⬇️
routers/repo/branch.go 55.51% <10.00%> (-1.84%) ⬇️
services/release/release.go 47.10% <45.71%> (-0.13%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e65286...c206b49. Read the comment docs.

a1012112796 and others added 10 commits November 29, 2020 17:14
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
  [skip ci] Updated translations via Crowdin
  Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2021
@zeripath zeripath merged commit 83cf1a8 into go-gitea:master Feb 28, 2021
@a1012112796 a1012112796 deleted the ui_create_tag branch March 4, 2021 07:36
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants