Revert "Replies to outdated code comments should also be outdated" #13439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Nov 6, 2020
GiteaBot
added
lgtm/done
lafriks
deleted the
revert-13217-comments-on-review-should-have-the-same-sha
branch
4 tasks
|
This should not have been reverted. The migration should have been fixed. |
|
It's not quick to fix that PR when I found the problem because of different database pagination SQL. Since the PR is only online for several hours, so I think revert is the quickest method to prevent more people to upgrade to that commit. |
|
migrations with raw SQL just need more 👀 on review ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13217, per https://github.com/go-gitea/gitea/pull/13217/files#r518531211 and https://github.com/go-gitea/gitea/pull/13217/files#r518531552