Skip to content

Add missing full names when DEFAULT_SHOW_FULL_NAME is enabled #13417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2020
Merged

Add missing full names when DEFAULT_SHOW_FULL_NAME is enabled #13417

merged 3 commits into from
Nov 4, 2020

Conversation

42wim
Copy link
Member

@42wim 42wim commented Nov 3, 2020

Hopefully possible for 1.13 ?:)

mrsdizzie
mrsdizzie suggested changes Nov 3, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2020
@lafriks
Copy link
Member

lafriks commented Nov 4, 2020

🚀

@codecov-io
Copy link

Codecov Report

Merging #13417 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13417      +/-   ##
==========================================
- Coverage   42.11%   42.11%   -0.01%     
==========================================
  Files         691      691              
  Lines       76003    76007       +4     
==========================================
  Hits        32010    32010              
- Misses      38744    38750       +6     
+ Partials     5249     5247       -2
Impacted Files Coverage Δ
models/migrations/v156.go 0.00% <0.00%> (ø)
routers/repo/blame.go 0.00% <0.00%> (ø)
models/repo_list.go 78.57% <0.00%> (-0.90%) ⬇️
models/error.go 35.22% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/queue/workerpool.go 59.59% <0.00%> (-0.41%) ⬇️
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c3cf6...2c4baa7. Read the comment docs.

@lafriks lafriks merged commit fb756e7 into go-gitea:master Nov 4, 2020
@lafriks
Copy link
Member

lafriks commented Nov 4, 2020

Please send backport

@lafriks lafriks added this to the 1.14.0 milestone Nov 4, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Nov 4, 2020
@42wim 42wim mentioned this pull request Nov 4, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@42wim @lafriks @codecov-io @mrsdizzie @gary-kim @GiteaBot @jolheiser