Skip to content

Remove double escape on labels addition in comments #12809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2020
Merged

Remove double escape on labels addition in comments #12809

merged 2 commits into from
Sep 11, 2020

Conversation

zeripath
Copy link
Contributor

Fix #12786

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added this to the 1.13.0 milestone Sep 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #12809 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12809      +/-   ##
==========================================
- Coverage   43.17%   43.16%   -0.02%     
==========================================
  Files         651      651              
  Lines       72134    72134              
==========================================
- Hits        31143    31135       -8     
- Misses      35939    35948       +9     
+ Partials     5052     5051       -1
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/git/blame.go 77.19% <0.00%> (+1.75%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd60ebf...7d70a2d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@techknowlogick techknowlogick merged commit bfd9ca3 into go-gitea:master Sep 11, 2020
techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Sep 11, 2020
@zeripath @lunny @techknowlogick
Remove double escape on labels addition in comments (go-gitea#12809)
eee3216 
Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
@techknowlogick techknowlogick mentioned this pull request Sep 11, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Sep 11, 2020
techknowlogick added a commit that referenced this pull request Sep 11, 2020
@techknowlogick @zeripath @lunny
Remove double escape on labels addition in comments (#12809) (#12810)
3757255 
Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@zeripath zeripath deleted the fix-12786-stop-double-escaping-labels branch December 29, 2022 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Labels are not rendered correctly in issue log
7 participants
@zeripath @codecov-commenter @mrsdizzie @6543 @techknowlogick @GiteaBot @lunny