Skip to content

Build windows using golang 1.14 #12489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

techknowlogick
Copy link
Member

Build windows binary using golang1.14 due to exported symbols size limit on windows: Error: export ordinal too large.

Tagged as skip changelog so it isn't reported in changelog file, but tagged as changelog so it is mentioned in the blog post.

@techknowlogick techknowlogick added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/changelog Adds the changelog for a new Gitea version skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 14, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 14, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workaround ,,,

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #12489 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12489      +/-   ##
==========================================
+ Coverage   43.75%   43.76%   +0.01%     
==========================================
  Files         631      631              
  Lines       69870    69870              
==========================================
+ Hits        30569    30580      +11     
+ Misses      34344    34336       -8     
+ Partials     4957     4954       -3     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
models/error.go 36.28% <0.00%> (+0.86%) ⬆️
models/notification.go 67.04% <0.00%> (+0.91%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/pull/check.go 50.00% <0.00%> (+1.53%) ⬆️
modules/notification/ui/ui.go 83.33% <0.00%> (+2.77%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef318e...4cffa83. Read the comment docs.

@techknowlogick techknowlogick merged commit b37c7dd into go-gitea:master Aug 14, 2020
@techknowlogick techknowlogick deleted the techknowlogick-patch-5 branch August 14, 2020 01:18
techknowlogick added a commit that referenced this pull request Aug 14, 2020
@lunny lunny removed the type/changelog Adds the changelog for a new Gitea version label Sep 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants