Skip to content

Update JS dependencies #12474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Update JS dependencies #12474

merged 2 commits into from
Aug 11, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 11, 2020

  • Update worker-loader options (currently unused pending Move eventsource.sharedworker to worker-loader #12459)
  • Remove @babel/plugin-proposal-object-rest-spread, it's enabled by default
  • Switch cssnano-webpack-plugin to css-minimizer-webpack-plugin which had been renamed

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #12474 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12474      +/-   ##
==========================================
+ Coverage   43.78%   43.82%   +0.03%     
==========================================
  Files         631      631              
  Lines       69851    69851              
==========================================
+ Hits        30587    30612      +25     
+ Misses      34330    34301      -29     
- Partials     4934     4938       +4     
Impacted Files Coverage Δ
services/pull/temp_repo.go 32.97% <0.00%> (-3.20%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
models/issue_comment.go 55.43% <0.00%> (+0.31%) ⬆️
services/pull/pull.go 43.87% <0.00%> (+0.46%) ⬆️
models/pull.go 55.17% <0.00%> (+0.62%) ⬆️
modules/git/repo.go 53.80% <0.00%> (+1.52%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
services/pull/check.go 56.15% <0.00%> (+16.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74bd969...b060fee. Read the comment docs.

- Update worker-loader options (currently unused pending go-gitea#12459)
- Remove @babel/plugin-proposal-object-rest-spread, it's enabled by
  default
- Switch cssnano-webpack-plugin to css-minimizer-webpack-plugin which
  had been renamed
@silverwind
Copy link
Member Author

One more change added:

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 11, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 11, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 11, 2020
@sapk
Copy link
Member

sapk commented Aug 11, 2020

Sorry I restarted the failed build without re-checking that one as passed before inbeetween.

@sapk sapk merged commit c18b052 into go-gitea:master Aug 11, 2020
@silverwind silverwind deleted the deps-13 branch August 12, 2020 06:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants