Skip to content

Add 'checks' Make and CI tasks #12352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2020
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 28, 2020

Introduce new "sanity" targets that perform tasks that we've been piling onto the linting tasks. This will make the linter tasks faster and hopefully encourage some users to use them locally.

@silverwind silverwind changed the title Split out ci tasks unrelated to linting Add 'sanity' Make and CI tasks Jul 28, 2020
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 4, 2020
@silverwind
Copy link
Member Author

Not sure I like the "sanity" name, guess we need something more fitting.

@silverwind silverwind changed the title Add 'sanity' Make and CI tasks Add 'checks' Make and CI tasks Aug 5, 2020
@silverwind
Copy link
Member Author

Renamed to "checks".

@silverwind
Copy link
Member Author

I'm not sure if misspell-check ever ran on the CI, but I've added it now.

@silverwind
Copy link
Member Author

silverwind commented Aug 6, 2020

Misspell successfully ran. I think this is ready for merge.

Introduce new "checks" targets that perform tasks that we've been piling
onto the linting tasks. This will make the linter tasks faster and
hopefully encourage some users to use them locally.
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 16, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12352 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12352      +/-   ##
==========================================
+ Coverage   43.73%   43.75%   +0.02%     
==========================================
  Files         631      631              
  Lines       69877    69877              
==========================================
+ Hits        30561    30578      +17     
+ Misses      34357    34344      -13     
+ Partials     4959     4955       -4     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
services/pull/pull.go 42.26% <0.00%> (+0.69%) ⬆️
services/pull/check.go 48.46% <0.00%> (+0.76%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
services/pull/update.go 57.69% <0.00%> (+5.76%) ⬆️
modules/indexer/stats/db.go 52.17% <0.00%> (+8.69%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+23.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e67d7...2dfb3a2. Read the comment docs.

@techknowlogick techknowlogick merged commit d285b5d into go-gitea:master Aug 16, 2020
@silverwind silverwind deleted the sanity branch August 17, 2020 06:30
silverwind added a commit to silverwind/gitea that referenced this pull request Aug 17, 2020
These targets are actually using plural names, fix help output for them.

Ref: go-gitea#12352
@silverwind silverwind mentioned this pull request Aug 17, 2020
techknowlogick pushed a commit that referenced this pull request Aug 17, 2020
These targets are actually using plural names, fix help output for them.

Ref: #12352
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants