fix: add type=text for user_name (password manager) #12250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
Jul 15, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
added
topic/ui
jaqra
reviewed
Jul 15, 2020
GiteaBot
added
the
lgtm/need 1
Co-authored-by: jaqra <[email protected]>
jaqra
approved these changes
Jul 15, 2020
GiteaBot
added
lgtm/done
lafriks
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using Passbolt as my password manager and form autocompletion does not work for the email. I noticed that input field needed
type="text"to make it working. Moreover, i think it is a better practice to have this property :)I added it everywhere there is the name property with the value
user_name.Any question are welcomed :)
Thank you for your work !