Ensure that zero-leading gpg key IDs verify #11685
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#10591 Signed-off-by: Andrew Thornton <[email protected]>
|
Hmm I think this fixes one thing but breaks another I need to rethink, essentially our db doesn't store preceding zeroes so we must match string without preceding zeroes. I will therefore close this whilst I re-attempt a fix. |
GiteaBot
added
the
lgtm/need 2
zeripath
deleted the
fix-10591-ensure-that-zero-preceding-fingerprints-can-sign
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert IDs to 16 character hexadecimals before matching with the DB.
Fix #10591
Signed-off-by: Andrew Thornton [email protected]