Skip to content

Enforce transparent background on editor toolbar elements #11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2020
Merged

Enforce transparent background on editor toolbar elements #11569

merged 2 commits into from
May 23, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 23, 2020

Before:
chrome_2020-05-23_02-21-45

After:
chrome_2020-05-23_02-21-24

Generally the issue was present only for .disabled-for-preview case via CSS from SimpleMDE:

.editor-toolbar.disabled-for-preview a:not(.no-disable) {
    pointer-events: none;
    background: #fff;
    border-color: transparent;
    text-shadow: inherit;
}

I have decided to ensure background is transparent globally, I have no idea why SimpleMDE would want to override backgrounds here, they don't do it for any other case.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 23, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 23, 2020
@lafriks lafriks merged commit 38c773d into go-gitea:master May 23, 2020
@lafriks
Copy link
Member

lafriks commented May 23, 2020

Please backport

@CirnoT CirnoT deleted the editor-toolbar_transparent branch May 23, 2020 14:23
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 23, 2020
@CirnoT @lafriks
Enforce transparent background on editor toolbar elements (go-gitea#1…
074680c 
…1569)

Co-authored-by: Lauris BH <[email protected]>
(cherry picked from commit 38c773d)
@CirnoT CirnoT mentioned this pull request May 23, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label May 23, 2020
techknowlogick pushed a commit that referenced this pull request May 23, 2020
@CirnoT @zeripath
Enforce transparent background on editor toolbar elements (#11569) (#…
80853a2 
…11583)

Co-authored-by: Lauris BH <[email protected]>
(cherry picked from commit 38c773d)

Co-authored-by: zeripath <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @lafriks
Enforce transparent background on editor toolbar elements (go-gitea#1…
b47681c 
…1569)

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CirnoT @lafriks @silverwind @mrsdizzie @GiteaBot