Remove last traces of has-emoji class

[mrsdizzie]

Now that emojify.js has been removed, get rid of all instances of has-emoji class that was only used for that. Support for rendering shortcodes remains in all of these places so it should still work the same.

[lafriks]

Does functions RenderCommitMessageLinkSubject and RenderCommitMessage does emoji rendering also?

[mrsdizzie]

Does functions RenderCommitMessageLinkSubject and RenderCommitMessage does emoji rendering also?

Yep:

gitea/modules/markup/html.go

Lines 200 to 210 in 4974b7c

	var commitMessageProcessors = []processor{
	fullIssuePatternProcessor,
	fullSha1PatternProcessor,
	linkProcessor,
	mentionProcessor,
	issueIndexPatternProcessor,
	sha1CurrentPatternProcessor,
	emailAddressProcessor,
	emojiProcessor,
	emojiShortCodeProcessor,
	}

(same for subject one below that too)

[6543]

I did not grep recursive for 'has-emoji' jet. But this should catch some ;)

[silverwind]

I take it the cases where only the class was removed and nothing added were already rendering correctly?

[mrsdizzie]

I take it the cases where only the class was removed and nothing added were already rendering correctly?

yep #11263 (comment) as an example

[6543]

$ rg 'has-emoji' options/locale/locale_en-US.ini
868:issues.add_label_at = added the <div class="ui label has-emoji" style="color: %s\; background-color: %s">%s</div> label %s
869:issues.remove_label_at = removed the <div class="ui label has-emoji" style="color: %s\; background-color: %s">%s</div> label %s

[6543]

had time to rg it ;) ☝️

[mrsdizzie]

$ rg 'has-emoji' options/locale/locale_en-US.ini
868:issues.add_label_at = added the

%s

label %s
869:issues.remove_label_at = removed the

%s

label %s

ah sneaky : ) rending for this was already fixed in template code but have removed class name from translations file

[6543]

👍

[codecov-io]

Codecov Report

Merging #11263 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11263      +/-   ##
==========================================
+ Coverage   43.29%   43.31%   +0.01%     
==========================================
  Files         605      605              
  Lines       86273    86275       +2     
==========================================
+ Hits        37354    37371      +17     
+ Misses      44314    44304      -10     
+ Partials     4605     4600       -5     

Impacted Files	Coverage Δ
modules/markup/html.go	79.97% <100.00%> (+0.05%)	⬆️
modules/indexer/stats/queue.go	62.50% <0.00%> (-18.75%)	⬇️
modules/indexer/stats/db.go	40.62% <0.00%> (-9.38%)	⬇️
modules/git/utils.go	65.67% <0.00%> (-4.48%)	⬇️
modules/git/repo.go	49.79% <0.00%> (-0.84%)	⬇️
models/issue.go	52.10% <0.00%> (+0.46%)	⬆️
modules/notification/webhook/webhook.go	40.20% <0.00%> (+0.58%)	⬆️
services/pull/pull.go	35.30% <0.00%> (+1.14%)	⬆️
modules/queue/unique_queue_disk_channel.go	55.76% <0.00%> (+1.92%)	⬆️
services/pull/temp_repo.go	34.18% <0.00%> (+2.56%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdffef...71d9467. Read the comment docs.