-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
API: Add pull review endpoints #11224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lafriks
merged 40 commits into
go-gitea:master
from
6543-forks:api-review-endpoints_5733
May 2, 2020
Merged
Changes from 2 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
bbdc5a0
API: Added pull review read only endpoints
tbe 44d32f0
Merge branch 'master' into api-review-endpoints_5733
6543 70dfe71
Update Structs, move Conversion, Refactor
6543 644aa1c
refactor
6543 79eca0b
lint & co
6543 0ce765c
fix lint + refactor
6543 d860be8
add new Review state, rm unessesary, refacotr loadAttributes, convert…
6543 a4b998c
add DeletePullReview
6543 582c6c0
Merge branch 'master' into api-review-endpoints_5733
6543 e1c13b0
add paggination
6543 4b60f40
draft1: Create & submit review
6543 4f95b62
Merge branch 'master' into api-review-endpoints_5733
6543 2f2c400
fix lint
6543 aeda695
fix lint
6543 ed15f52
Merge branch 'master' into api-review-endpoints_5733
6543 63c7b4e
Merge branch 'master' into api-review-endpoints_5733
6543 ef2047d
impruve test
6543 42a6b89
DONT use GhostUser for loadReviewer
6543 5a6f383
expose comments_count of a PullReview
6543 eedd1f2
infent GetCodeCommentsCount()
6543 ac86f43
fixes
6543 75f6c1b
fix+impruve
6543 efd8bb9
Merge branch 'master' into api-review-endpoints_5733
6543 c7cd256
Merge branch 'master' into api-review-endpoints_5733
6543 627b9d6
some nits
6543 0cf99dc
Handle Ghosts :ghost:
6543 d9e1480
add TEST for GET apis
6543 cbca510
complete TESTS
6543 9b0bbc1
add HTMLURL to PullReview responce
6543 ac9a31f
code format as per @lafriks
6543 c7722ae
Merge branch 'master' into api-review-endpoints_5733
6543 28d4f34
update swagger definition
6543 ab3edb3
Merge branch 'master' into api-review-endpoints_5733
6543 55f37fd
Merge branch 'master' into api-review-endpoints_5733
6543 65dc905
Merge branch 'master' into api-review-endpoints_5733
6543 ff661a9
Merge branch 'master' into api-review-endpoints_5733
6543 5af6fc5
Merge branch 'master' into api-review-endpoints_5733
6543 d1ae269
Update routers/api/v1/repo/pull_review.go
6543 e66b139
add comments
6543 42dfbe7
Merge branch 'master' into api-review-endpoints_5733
6543 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright 2020 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package structs | ||
|
||
import ( | ||
"time" | ||
) | ||
|
||
// PullRequestReview represents a pull request review | ||
type PullRequestReview struct { | ||
ID int64 `json:"id"` | ||
PRURL string `json:"pull_request_url"` | ||
Reviewer *User `json:"user"` | ||
Body string `json:"body"` | ||
CommitID string `json:"commit_id"` | ||
Type string `json:"type"` | ||
|
||
// swagger:strfmt date-time | ||
Created time.Time `json:"created_at"` | ||
6543 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// TODO: is there a way to get a URL to the review itself? | ||
// HTMLURL string `json:"html_url"` | ||
} | ||
|
||
// PullRequestReviewComment represents a comment on a pull request | ||
type PullRequestReviewComment struct { | ||
ID int64 `json:"id"` | ||
URL string `json:"url"` | ||
PRURL string `json:"pull_request_url"` | ||
ReviewID int64 `json:"pull_request_review_id"` | ||
Path string `json:"path"` | ||
CommitID string `json:"commit_id"` | ||
DiffHunk string `json:"diff_hunk"` | ||
LineNum uint64 `json:"position"` | ||
OldLineNum uint64 `json:"original_position"` | ||
Reviewer *User `json:"user"` | ||
Body string `json:"body"` | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.