Skip to content

Fix internal server error on checkboxes #10845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 26, 2020

Annoyingly goldmarks SetAttributeString requires that
the value of the attribute is still a []byte but does
not make it clear in the documentation.

Fix #10842

Signed-off-by: Andrew Thornton [email protected]

Annoyingly goldmarks SetAttributeString requires that
the value of the attribute is still a []byte but does
not make it clear in the documentation.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.12.0 milestone Mar 26, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #10845 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10845      +/-   ##
==========================================
+ Coverage   43.49%   43.51%   +0.01%     
==========================================
  Files         590      590              
  Lines       82806    82806              
==========================================
+ Hits        36020    36034      +14     
+ Misses      42308    42293      -15     
- Partials     4478     4479       +1     
Impacted Files Coverage Δ
modules/markup/markdown/goldmark.go 64.95% <0.00%> (ø)
modules/queue/workerpool.go 55.87% <0.00%> (-1.07%) ⬇️
services/pull/pull.go 35.00% <0.00%> (-0.89%) ⬇️
modules/indexer/stats/db.go 50.00% <0.00%> (ø)
routers/repo/view.go 36.82% <0.00%> (+0.67%) ⬆️
models/notification.go 64.71% <0.00%> (+0.83%) ⬆️
modules/git/repo.go 47.70% <0.00%> (+0.91%) ⬆️
modules/log/event.go 65.64% <0.00%> (+1.02%) ⬆️
modules/log/file.go 77.62% <0.00%> (+2.09%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd910e...1840611. Read the comment docs.

@zeripath zeripath merged commit cf4f2cf into go-gitea:master Mar 26, 2020
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 26, 2020
@zeripath zeripath deleted the fix-10842 branch March 26, 2020 23:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repo page 500 because of markdown render error
5 participants