Skip to content

docs: Fix MySQL create database syntax #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020
Merged

docs: Fix MySQL create database syntax #10436

merged 1 commit into from
Feb 24, 2020

Conversation

abh
Copy link
Contributor

@abh abh commented Feb 24, 2020

Signed-off-by: Ask Bjørn Hansen [email protected]

@codecov-io
Copy link

Codecov Report

Merging #10436 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10436      +/-   ##
==========================================
+ Coverage   43.67%   43.68%   +<.01%     
==========================================
  Files         586      586              
  Lines       81389    81389              
==========================================
+ Hits        35550    35556       +6     
+ Misses      41439    41433       -6     
  Partials     4400     4400
Impacted Files Coverage Δ
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/git/repo.go 46.78% <0%> (-2.3%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
models/notification.go 64.13% <0%> (+0.84%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
modules/git/command.go 89.56% <0%> (+2.6%) ⬆️
services/pull/check.go 53.04% <0%> (+3.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b507e...efa7925. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2020
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Feb 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2020
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks would be the canonical way, but this is fine too.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2020
@lafriks lafriks merged commit c97433d into go-gitea:master Feb 24, 2020
@abh
Copy link
Contributor Author

abh commented Feb 25, 2020

@silverwind I thought backticks would have too many way to get mangled between document conversions, cut'n'paste, etc to be worth it. If someone chooses a database name that needs backticks they'd have to figure that out without the gitea documentation helping them. :-)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants