Skip to content

Fix 500 when use a duplicate email instead of giving an error tip #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 24, 2017

This will part to resolve #13 . And This also formatted the code by my vscode go plugin.

@lunny lunny added the type/bug label Feb 24, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 24, 2017
@strk
Copy link
Member

strk commented Feb 24, 2017

Please don't mix functional and style changes.
The code you add seem to be suffering from race conditions, that is the mail might be non-existent at time of checking but be inserted later, at time of user update/insert transaction

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2017
@lunny
Copy link
Member Author

lunny commented Feb 24, 2017

I will split this into 2 PRs.

@andreynering
Copy link
Contributor

Trusted LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2017
@lunny lunny merged commit 19b3c45 into go-gitea:master Feb 25, 2017
@lunny lunny deleted the lunny/fix_500_login_same_email branch April 19, 2017 05:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different users with same e-mail causes error on create repositores and user creation from register
5 participants