-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Feature & Proposal] Halting Log Output and Graceful Restart/Stop #9960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. You can re-open it if needed. |
@bagasme I'm also handling log rotation myself, using logrotate. (Must do so, so can feed logs into log management stack.) The gitea container already runs s6, so log rotation would be very easy. With s6 I would typically do:
Which would make s6 send signal But of course gitea doesn't currently support reopening of its log file. Have you found a workaround in the meantime? |
Description
As @zeripath mentioned in #9930, we need a way to halt log output. This may be required for using
logrotate
for example.We can introduce graceful restart and stop to achieve the feature mentioned above. In graceful stop, the Gitea process isn't immediately stopped, but let the remaining requests to be processed prior to stop. Graceful restart use similar technique, instead that new requests are served using new generation of Gitea process.
The text was updated successfully, but these errors were encountered: