Skip to content

Merge commits generated by pull request capture no pull request detail #9552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
themightychris opened this issue Dec 30, 2019 · 0 comments
Closed

Merge commits generated by pull request capture no pull request detail #9552

themightychris opened this issue Dec 30, 2019 · 0 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.12.0

Comments

@themightychris
Copy link

themightychris commented Dec 30, 2019 •
edited
Loading

On Github, the merge commit generated from merging a pull request through the UI includes both the PR # and the description copy from the PR:

Merge pull request #{ISSUE_NUMBER} from {SOURCE_REPO}/{SOURCE_BRANCH}

{ISSUE_DESCRIPTION}

Gitea however generates a merge commit without any reference to the PR issue number:

Merge branch '{SOURCE_BRANCH}' of {SOURCE_REPO} into {TARGET_BRANCH}

Not that Gitea has to exactly replicate what Github does, but the inability to correlate merges back to their pull request easily creates a big pain point. Further, it is very helpful for the pull request description to make it into the history
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 31, 2019
@shashvat-kedia shashvat-kedia mentioned this issue Jan 7, 2020
Merged
shashvat-kedia added a commit to shashvat-kedia/gitea that referenced this issue Jan 8, 2020
@shashvat-kedia
Fix go-gitea#9552: Merge commits generated by pull request capture pu…
754d12e 
…ll request details
@lunny lunny added this to the 1.12.0 milestone Jan 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.12.0
Development

No branches or pull requests
2 participants
@lunny @themightychris