Skip to content

API /issues endpoint doesn't not propograte query parameters in pagination links #7296

Closed
@jerrykan

Description

@jerrykan
  • Gitea version (or commit ref): 1.9.0+dev-377-g5908bb103
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

When making an API request to the /issues endpoint the query string parameters are not propagated to in the URLs provided in the Link response header.

curl -I -H  "accept: application/json" -H  "authorization: Basic XXXXXX" -X GET "https://try.gitea.io/api/v1/repos/jerrykan/example-repo/issues?state=all"
HTTP/2 200 
content-type: application/json; charset=UTF-8
date: Wed, 26 Jun 2019 02:07:50 GMT
link: <https://try.gitea.io/api/v1/repos/jerrykan/example-repo/issues?page=2>; rel="next",<https://try.gitea.io/api/v1/repos/jerrykan/example-repo/issues?page=3>; rel="last"
set-cookie: XXXXXX
set-cookie: XXXXXX
set-cookie: XXXXXX
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN

I would expect the Link response header to instead be something like:

link: <https://try.gitea.io/api/v1/repos/jerrykan/example-repo/issues?page=2?state=all>; rel="next",<https://try.gitea.io/api/v1/repos/jerrykan/example-repo/issues?page=3?state=all>; rel="last"

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions