-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Open
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionalityAn improvement of existing functionality
Description
If there are multiple people committing into a branch which is then used as a source for a pull request it is currently possible for reviewers, who also committed, to approve the changes.
I think it would be valuable if the branch protection had a setting to disallow approval by commiters within the PR, as it is currently the default to disallow approval by the PR author.
informeti
Metadata
Metadata
Assignees
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionalityAn improvement of existing functionality