Gitea 1.5.0 fails to run (segfaults)

[tgurr]

• Gitea version (or commit ref): 1.5.0
• Git version: 2.18.0
• Operating system: Linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Aug 13 15:39:19 localhost systemd[1]: Started Gitea (Git with a cup of tea).
Aug 13 15:39:19 localhost gitea[23535]: panic: runtime error: invalid memory address or nil pointer dereference
Aug 13 15:39:19 localhost gitea[23535]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7be913]
Aug 13 15:39:19 localhost gitea[23535]: goroutine 1 [running]:
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).transformValue(0xc4202d2ea0, 0xc4202cc691, 0x28, 0xc4204cce48, 0x4ac519)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:123 +0xa3
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).String(0xc4202d2ea0, 0xc4202cb320, 0x15)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:130 +0x3d
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).MustString(0xc4202d2ea0, 0xc4202cb320, 0x15, 0x1, 0xc4202cb320)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:202 +0x2f
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/modules/setting.NewContext()
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/modules/setting/setting.go:1151 +0x4526
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/routers.GlobalInit()
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/routers/init.go:47 +0x4a
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/cmd.runWeb(0xc42036ea00, 0x0, 0x0)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/cmd/web.go:83 +0xa8
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/github.com/urfave/cli.HandleAction(0x10846a0, 0x1270720, 0xc42036ea00, 0xc420094e00, 0x0)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:471 +0xad
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/github.com/urfave/cli.Command.Run(0x1217d01, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x123677a, 0x16, 0x0, ...)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/command.go:191 +0xa0e
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/github.com/urfave/cli.(*App).Run(0xc42001a340, 0xc4200b4040, 0x4, 0x4, 0x0, 0x0)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:241 +0x5b8
Aug 13 15:39:19 localhost gitea[23535]: main.main()
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/main.go:52 +0x40e
Aug 13 15:39:19 localhost systemd[1]: gitea.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Aug 13 15:39:19 localhost systemd[1]: gitea.service: Failed with result 'exit-code'.

Description

Trying to run 1.5.0 after compiling using go 1.10.3 results in the following error message. Compiling and running the previous Gitea 1.4.3 with the same options works fine. I ran into this when trying to upgrade an instance with 1.4.3 to 1.5.0, but it's also reproducible on another host with no previous Gitea installation/configuration/data present.

[lafriks]

Can you provide app.ini you are using as it seems to be problem in it.

[rbong]

I am getting the same error with 1.5.0. If I don't comment out either of the last two lines from app.ini, which I pulled from app.ini.example.

[U2F]
APP_ID = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/
TRUSTED_FACETS = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/

[tgurr]

Commenting out the [U2F] section does the trick or me as well, thanks @rbong.

[eripa]

Same for me. Segfaulting unless I remove the U2F section. U2F still works with it removed though.. so maybe it's no longer needed?

[lafriks]

If removed it gitea uses defaults as given in sample app.ini file

[eripa]

Ok. This is the one I had:

[U2F]
APP_ID = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s
TRUSTED_FACETS = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s

I grabbed the U2F section from here: https://github.com/go-gitea/gitea/blob/master/custom/conf/app.ini.sample#L630

(the only difference was that it had trailing / on each setting)

and added that instead of nothing and it got back into segfaulting. There seems to be a difference between having this configured at all and just leaving it out.

[lafriks]

I think that / at the end is critical

[eripa]

I tried with the /, same issue.

…

On Aug 19, 2018, at 12:02, Lauris BH ***@***.***> wrote: I think that / at the end is critical — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[rain0r]

Edit: Downgrading to 1.4.3 fixed the issue.

I'm experiencing the same error since upgrading to gitea-1.5.2.

Gitea version (or commit ref): 1.5.2
Git version: 2.19.1
Operating system: Gentoo Linux
Database: PostgreSQL 10.5

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7f3654]

goroutine 1 [running]:
code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).transformValue(0xc0002afc20, 0xc000041861, 0x28, 0xc0004eee70, 0x4af6f9)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:123 +0xa4
code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).String(0xc0002afc20, 0xc0002ad320, 0x14)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:130 +0x3d
code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).MustString(0xc0002afc20, 0xc0002ad320, 0x14, 0x1, 0xc0002ad320)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:202 +0x2f
code.gitea.io/gitea/modules/setting.NewContext()
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/modules/setting/setting.go:1151 +0x45f4
code.gitea.io/gitea/routers.GlobalInit()
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/routers/init.go:47 +0x4a
code.gitea.io/gitea/cmd.runWeb(0xc00032e8c0, 0x0, 0x0)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/cmd/web.go:83 +0xaa
code.gitea.io/gitea/vendor/github.com/urfave/cli.HandleAction(0x12e1b80, 0x14dc4f0, 0xc00032e8c0, 0xc0000a9800, 0x0)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:471 +0xad
code.gitea.io/gitea/vendor/github.com/urfave/cli.Command.Run(0x146aae8, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1490463, 0x16, 0x0, ...)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/command.go:191 +0x96d
code.gitea.io/gitea/vendor/github.com/urfave/cli.(*App).Run(0xc0002844e0, 0xc0000aa040, 0x4, 0x4, 0x0, 0x0)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:241 +0x5a2
main.main()
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/main.go:52 +0x3a7

[lunny]

It seems it's a upstream library gopkg.in/ini.v1's bug.

[stefangweichinger]

I also see gitea-1.5.2 fail with the U2F-section in app.ini ... and initially I added that section because adding my U2F-key (yubikey) does not work. The button "Add Security Key" does nothing here.

The URL /user/settings/security/u2f/request_register fails ... according to the 404 mentioned in my dev-tools (chrome).

[ArchangeGabriel]

Still present with 1.6.0.