Skip to content

go-bindata is no longer maintained #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonasfranz opened this issue Jun 15, 2018 · 13 comments · Fixed by #7080
Closed

go-bindata is no longer maintained #4250

jonasfranz opened this issue Jun 15, 2018 · 13 comments · Fixed by #7080
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Milestone

Comments

@jonasfranz
Copy link
Member

go-bindata is no longer maintained as stated here: https://github.com/jteeuwen/go-bindata#warning

We should replace it with a maintained alternative like packr.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 15, 2018
@lunny
Copy link
Member

lunny commented Jun 15, 2018

But maybe continue with https://github.com/go-bindata/go-bindata ?

@lunny
Copy link
Member

lunny commented Jun 15, 2018

I don't like packr build.

@bkcsoft
Copy link
Member

bkcsoft commented Jun 15, 2018

@lunny You don't need to run packr build, you could (like we do now with go-bindata) run packr followed by go build :|

@axifive
Copy link
Member

axifive commented Jun 16, 2018

And there is another maintained alternative: https://github.com/rakyll/statik

@tboerger
Copy link
Member

I would suggest fileb0x

@stale
Copy link

stale bot commented Jan 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 22, 2019
@edacval
Copy link

edacval commented Jan 23, 2019

Arch Linux uses https://github.com/shuLhan/go-bindata

@stale stale bot removed the issue/stale label Jan 23, 2019
@sapk
Copy link
Member

sapk commented Jan 23, 2019

https://github.com/mjibson/esc is simple to use.

@tboerger
Copy link
Member

Esc doesn't support tags, tags are required for gitea.

@stale
Copy link

stale bot commented Mar 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 24, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 24, 2019
@stale stale bot removed the issue/stale label Mar 24, 2019
@lunny
Copy link
Member

lunny commented May 29, 2019

Just found https://github.com/shurcooL/vfsgen, I think it maybe a better solution than others because it's a library and could be put in vendor and will resolve package dependency on building process. We can write a command with a special build flag which will only be run on build process.

@lafriks
Copy link
Member

lafriks commented May 29, 2019

@lunny I tested it a bit some time ago and it does looks quite good: https://github.com/lafriks/gitea-rewrite-experiment/tree/master/modules/template

@tboerger
Copy link
Member

I'm using filb0x so far for other projects which is working really good.

@lafriks lafriks added this to the 1.9.0 milestone Jun 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants