Skip to content

Proposal: Drop integrated tidb support #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sapk opened this issue May 18, 2018 · 5 comments
Closed

Proposal: Drop integrated tidb support #3990

sapk opened this issue May 18, 2018 · 5 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.6.0

Comments

@sapk
Copy link
Member

sapk commented May 18, 2018

TiDB since v2 seems to drop the integrated database model and shift to provide a scalable/distributed/mysql compatible independant database server.
So I propose to drop support for the old version that seems to not be use and we haven't provided test or binary for it. We should still be compatible since TiDB is compatible with mysql.

I might be misleading so this PR is to find out if someone use it or if everyone is ok with this proposal.
@sapk
Copy link
Member Author

sapk commented May 18, 2018 •
edited
Loading 

I had some changes in /vendor kept from when trying to update to last v1 version that was failing.

@lunny
Copy link
Member

lunny commented May 19, 2018

Since we could use xgo to cross-compile sqlite. I think remove embed tidb support is acceptable.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 19, 2018
@sapk
Copy link
Member Author

sapk commented May 19, 2018

PR ready as this is easy (#3993) but before I think we should wait if anyone complain.

@techknowlogick
Copy link
Member

What if we announce that we are going to do this in the 1.5.0 release blog post, and then merge it into master right after 1.5.0 is released that way it will be in 1.6.0

@lafriks lafriks added this to the 1.6.0 milestone May 22, 2018
@techknowlogick
Copy link
Member

I've added the note about this to the upcoming 1.5.0 blog post, and PR has been merged so I will close this ticket.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
4 participants
@lunny @techknowlogick @lafriks @sapk