-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Cannot add attachments when editing an issue #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is available on gitea, but it looks like it was removed by the instance administrator (section |
Thanks for the reply, @thehowl
Here's another screenshot that more clearly demonstrates the problem: as you can see, the "add comment" box has the attachment selector but when the existing issue is edited, that same feature does not appear: |
Woops, should have paid more attention! Thanks for the explanation. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
Image pasting also don't work when editing. |
Hi, I am working on this issue recently. I would like to reuse dropzone's UI to allow user editing attachment. Here is the preview of current progress: When user click edit button on issue with attachments: I would like to know if it's a good idea. The update is almost done, just remaining |
This fixes `initRepoPullRequestAllowMaintainerEdit()` to submit the form correctly (as a web form, rather than as JSON payload). Fixes go-gitea#3618, cherry picked from gitea#30854. Co-Authored-By: wxiaoguang <[email protected]> --- Manual testing steps: - Open a PR against any repository, with the "Allow edits from maintainers" option checked. - Open the developer console (`Ctrl-Shift-I` on Firefox), and look at the Network tab. - Visit the PR, find the "Allow edits from maintainers" checkbox, and click it. - See the developer console, and check that the response says the setting is false. - Refresh the page *completely* (`Ctrl-Shift-R` on Firefox) - Observe that the setting is off. - Click the box again to enable it. - See the developer console, and check that the response says the setting is true. - Reload without cache again (`Ctrl-Shift-R` on Firefox) - Observe that the setting is now on. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3675 Reviewed-by: Earl Warren <[email protected]> Co-authored-by: Gergely Nagy <[email protected]> Co-committed-by: Gergely Nagy <[email protected]> (cherry picked from commit f4dd53d)
[x]
): N/ADescription
When editing an issue, gitea does not offer an option to add a new attachment. The first post in an issue should always be fully editable so that relevant information may be added to it (if the team's workflow is so designed) so relevant information can always be accessible without searching through the entire thread.
Screenshots
Here is a screenshot of the web ui as it appears when attempting to edit an issue:
As can be seen, the prompt to drag-and-drop a file to upload is not present. There is no other limitation I can see on changes that can be made retroactively, so this should be supported.
The text was updated successfully, but these errors were encountered: