Skip to content

Cannot add attachments when editing an issue #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
mqudsi opened this issue Mar 3, 2018 · 6 comments
Closed
1 of 3 tasks

Cannot add attachments when editing an issue #3618

mqudsi opened this issue Mar 3, 2018 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Milestone

Comments

@mqudsi
Copy link
Contributor

mqudsi commented Mar 3, 2018

  • Gitea version (or commit ref): 990709d
  • Git version: N/A
  • Operating system: N/A
  • Database (use [x]): N/A
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist: N/A

Description

When editing an issue, gitea does not offer an option to add a new attachment. The first post in an issue should always be fully editable so that relevant information may be added to it (if the team's workflow is so designed) so relevant information can always be accessible without searching through the entire thread.

Screenshots

Here is a screenshot of the web ui as it appears when attempting to edit an issue:

image

As can be seen, the prompt to drag-and-drop a file to upload is not present. There is no other limitation I can see on changes that can be made retroactively, so this should be supported.

@thehowl
Copy link
Contributor

thehowl commented Mar 3, 2018

This is available on gitea, but it looks like it was removed by the instance administrator (section [attachment], variable ENABLE, which must be set to true)

@mqudsi
Copy link
Contributor Author

mqudsi commented Mar 3, 2018

Thanks for the reply, @thehowl

ENABLE is actually set to true and attachments can be uploaded fine in new issues or new comments, but not when editing the existing issue after it has been created.

Here's another screenshot that more clearly demonstrates the problem: as you can see, the "add comment" box has the attachment selector but when the existing issue is edited, that same feature does not appear:

image

@thehowl
Copy link
Contributor

thehowl commented Mar 3, 2018

Woops, should have paid more attention! Thanks for the explanation.

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 3, 2018
@lunny lunny added this to the 1.x.x milestone Mar 3, 2018
@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 7, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 7, 2019
@stale stale bot removed the issue/stale label Feb 7, 2019
@NateScarlet
Copy link
Contributor

Image pasting also don't work when editing.
Only way to use new image is paste it to comment field then ctrl+x the link

@blueworrybear
Copy link
Contributor

Hi, I am working on this issue recently.

I would like to reuse dropzone's UI to allow user editing attachment.

Here is the preview of current progress:

edit-attachment0

When user click edit button on issue with attachments:

edit-attachment1

I would like to know if it's a good idea. The update is almost done, just remaining UpdateCommentContent need to be updated.

@lafriks lafriks closed this as completed Oct 15, 2019
@lafriks lafriks modified the milestones: 1.x.x, 1.11.0 Oct 15, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
This fixes `initRepoPullRequestAllowMaintainerEdit()` to submit the form correctly (as a web form, rather than as JSON payload).

Fixes go-gitea#3618, cherry picked from gitea#30854.

Co-Authored-By: wxiaoguang <[email protected]>

---

Manual testing steps:

- Open a PR against any repository, with the "Allow edits from maintainers" option checked.
- Open the developer console (`Ctrl-Shift-I` on Firefox), and look at the Network tab.
- Visit the PR, find the "Allow edits from maintainers" checkbox, and click it.
- See the developer console, and check that the response says the setting is false.
- Refresh the page *completely* (`Ctrl-Shift-R` on Firefox)
- Observe that the setting is off.
- Click the box again to enable it.
- See the developer console, and check that the response says the setting is true.
- Reload without cache again (`Ctrl-Shift-R` on Firefox)
- Observe that the setting is now on.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3675
Reviewed-by: Earl Warren <[email protected]>
Co-authored-by: Gergely Nagy <[email protected]>
Co-committed-by: Gergely Nagy <[email protected]>
(cherry picked from commit f4dd53d)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants